Problems with new email accounts

**Nuxwin** · Oct 18th 2017

@TheCry

I'm able to reproduce:

Shell-Script

Last applied update: 270Last available update: 272[ERROR] Database update 272 failed: SQLSTATE[42000]: Syntax error or access violation: 1091 Can't DROP 'domain_id'; check that column/key exists

I've used following code to mock: test.php

PHP

<?php
use iMSCP\Update\UpdateDatabaseAbstract;
use iMSCP_Registry as Registry;
define('IMSCP_SETUP', true);
require_once '/var/www/imscp/gui/library/imscp-lib.php';
class TestUpdate extends UpdateDatabaseAbstract
{
protected $lastUpdate = 272;
public function __construct()
{
parent::__construct();
// Reset revision to r270 (last from 1.5.x branch)
$this->dbConfig['DATABASE_REVISION'] = 270;
}
// Reset structure back to pre r267 update
protected function r271() {
return [
$this->dropTable('old_php_ini'),
$this->dropIndexByName('php_ini', 'unique_php_ini'),
$this->addIndex('php_ini', 'admin_id', 'KEY'),
$this->addIndex('php_ini', 'domain_id', 'KEY'),
$this->addIndex('php_ini', 'domain_type', 'KEY')
];
}
// Update structure as done in update r267
protected function r272()
{
if (($renameQuery = $this->renameTable('php_ini', 'old_php_ini')) !== NULL) {
execute_query($renameQuery);
}
if (!$this->isKnownTable('php_ini')) {
execute_query('CREATE TABLE php_ini LIKE old_php_ini');
}
if (($dropQueries = $this->dropIndexByColumn('php_ini', 'admin_id'))) {
foreach ($dropQueries as $dropQuery) {
execute_query($dropQuery);
}
}
if (($dropQueries = $this->dropIndexByColumn('php_ini', 'domain_id'))) {
foreach ($dropQueries as $dropQuery) {
execute_query($dropQuery);
}
}
if (($dropQuery = $this->dropIndexByColumn('php_ini', 'domain_type'))) {
foreach ($dropQueries as $dropQuery) {
execute_query($dropQuery);
}
}
return [
$this->addIndex('php_ini', ['admin_id', 'domain_id', 'domain_type'], 'UNIQUE', 'unique_php_ini'),
'INSERT IGNORE INTO php_ini SELECT * FROM old_php_ini',
$this->dropTable('old_php_ini')
];
}
}
function upddb_process()
{
$dbUpdater = new TestUpdate();
print "Last applied update: {$dbUpdater->getLastAppliedUpdate()}\n";
print "Next update: {$dbUpdater->getLastUpdate()}\n";
if ($dbUpdater->getLastAppliedUpdate() > $dbUpdater->getLastUpdate()) {
throw new iMSCP_Exception('An i-MSCP downgrade attempt has been detected. Downgrade is not supported.');
}
if (!$dbUpdater->applyUpdates()) {
fwrite(STDERR, sprintf("[ERROR] %s\n", $dbUpdater->getError()));
exit(1);
}
}
try {
if (version_compare(PHP_VERSION, '7', '<')) {
upddb_process();
} else {
try {
upddb_process();
} catch (Throwable $e) {
throw new Exception($e->getMessage(), $e->getCode(), $e);
}
}
} catch (Exception $e) {
$prevException = $e->getPrevious();
fwrite(STDERR, sprintf("[ERROR] %s \n\nStack trace:\n\n%s\n",$e->getMessage(),($prevException) ? $prevException->getTraceAsString() : $e->getTraceAsString()
));
exit(1);
}

Display More

Now, I'll be able to fix the issue

**Nuxwin** · Oct 18th 2017

@TheCry

Bug found and that is realy realy weird...

Shell-Script

root@buster:~# php updDB.phpLast applied update: 270Last available update: 272ALTER TABLE `php_ini` DROP INDEX `admin_id`ALTER TABLE `php_ini` DROP INDEX `domain_id`ALTER TABLE `php_ini` DROP INDEX `domain_id`

So basically, last query should be ALTER TABLE `php_ini` DROP INDEX `domain_type` :

PHP

...
if (($dropQuery = $this->dropIndexByColumn('php_ini', 'domain_type'))) {
foreach ($dropQueries as $dropQuery) {
#execute_query($dropQuery);
print "$dropQuery\n";
}
}
...

but query returned is: ALTER TABLE `php_ini` DROP INDEX `domain_id`

**Nuxwin** · Oct 18th 2017

@TheCry

Ok.. Typo there... Correct statement should be

PHP

if (($dropQueries = $this->dropIndexByColumn('php_ini', 'domain_type'))) {
foreach ($dropQueries as $dropQuery) {
execute_query($dropQuery);
}
}

$dropQueries instead of $dropQuery in the if statement. That was simply wrong variable name used.. How a typo can lead to failure...

**Nuxwin** · Oct 18th 2017

@TheCry @adrian.rico

Regarding the database failure (r267), a fix has been added in our development branch. See https://github.com/i-MSCP/imsc…441c2c0ed564d71328a457872
This fix will be part of next release.

Thank you both for your report.

adrian.rico · Oct 19th 2017

Hi @Nuxwin and @TheCry ,

Thank you very much for your support.

Our MySQL version is Ver 14.14 Distrib 5.5.57.
And our i-MSCP current version is 1.2.9 and I was trying to upgrade to the latest stable one 1.5.1.

Please let me know how to proceed, do you need finally anything from my side or you fixed it with the new update?

Otherwise, please could you tell me about the installation mode? Is it better to use Auto or Manual mode?
This is because as I said before when doing the setup of the install it is asking me for users and passwords of each service (dovecot, vsftp, mysql, phpmyadmin, ...) and I do not know if the ones being prompted are the same credentials used in the past, I don't want to fuck all the existing data.

Thank you in advance.

**Nuxwin** · Oct 19th 2017

Quote from adrian.rico

Otherwise, please could you tell me about the installation mode? Is it better to use Auto or Manual mode?

auto mode is best suitable for beginners.

The issue is fixed in git version. You can upgrade using the https://github.com/i-MSCP/imsc…9c368c021bd2055b5d.tar.gz archive which old all bugfixes.

**TheCry** · Oct 19th 2017

@adrian.rico

You had extracted the imscp package on your server?

~~You only need to replace the content of the file "gui/library/iMSCP/Update/UpdateDatabase.php" with this content https://github.com/i-MSCP/imsc…Update/UpdateDatabase.php~~
~~After this run the setup~~

EDIT BY NUXWIN: See below for the reason.

Yes the same credentials will be used. Only some databse credentials which have special chars in the password must be changed.

If you don't know how it works, it is possible to pay some money for exclussiv support and @Nuxwin will do the update for you

**Nuxwin** · Oct 19th 2017

Quote from TheCry

You only need to replace the content of the file "gui/library/iMSCP/Update/UpdateDatabase.php" with this content github.com/i-MSCP/imscp/blob/1…Update/UpdateDatabase.php

Not really

The class has been refactored a lot. There is an abstract class now on top. He could copy the body of the r271 method (1.5.x branch) into the body of r267 method from version 1.5.1 but nothing more

Problems with new email accounts

Share

Daily visitors