Let's Encrypt Renew wont work anymore

**TheCry** · Apr 30th 2019

Hi Laurent

I have some trouble with the latest version of Let's Encrypt on Debian 9.9.

The renew wont work anymore

I got this message in the status

Code

Can't locate Array/Diff.pm in @INC (you may need to install the Array::Diff module) (@INC contains: /var/www/imscp/gui/plugins/InstantSSH/backend /var/www/imscp/gui/plugins/InstantSSH/backend/Vendor /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/../../../../engine/PerlLib /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/../../../../engine/PerlVendor /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base)
at /var/www/imscp/gui/plugins/LetsEncrypt/backend/LetsEncrypt.pm line 976.
Plugin::LetsEncrypt::_getCertRequiredAction(Plugin::LetsEncrypt=HASH(0x55af0eab8b40), "/etc/letsencrypt/live/domain.tld/cert.pem", "domain.tld", "www.domain.tld") called at /var/www/imscp/gui/plugins/LetsEncrypt/backend/LetsEncrypt.pm line 736
Plugin::LetsEncrypt::_issueCertificate(Plugin::LetsEncrypt=HASH(0x55af0eab8b40), HASH(0x55af0eab90c8)) called at /var/www/imscp/gui/plugins/LetsEncrypt/backend/LetsEncrypt.pm line 373
eval {...} called at /var/www/imscp/gui/plugins/LetsEncrypt/backend/LetsEncrypt.pm line 371
eval {...} called at /var/www/imscp/gui/plugins/LetsEncrypt/backend/LetsEncrypt.pm line 357
Plugin::LetsEncrypt::run(Plugin::LetsEncrypt=HASH(0x55af0eab8b40), undef, undef) called at /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/../../../../engine/PerlLib/Modules/Plugin.pm line 438
eval {...} called at /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/../../../../engine/PerlLib/Modules/Plugin.pm line 438
Modules::Plugin::_executePluginAction(Modules::Plugin=HASH(0x55af0e80f428), "run") called at /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/../../../../engine/PerlLib/Modules/Plugin.pm line 387
Modules::Plugin::_run(Modules::Plugin=HASH(0x55af0e80f428)) called at /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/../../../../engine/PerlLib/Modules/Plugin.pm line 95
Modules::Plugin::process(Modules::Plugin=HASH(0x55af0e80f428), 4) called at /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/../../../../engine/PerlLib/iMSCP/DbTasksProcessor.pm line 520
iMSCP::DbTasksProcessor::_processModuleTasks(iMSCP::DbTasksProcessor=HASH(0x55af0e7edbe8), "Modules::Plugin", 4) called at /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/../../../../engine/PerlLib/iMSCP/DbTasksProcessor.pm line 487
eval {...} called at /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/../../../../engine/PerlLib/iMSCP/DbTasksProcessor.pm line 453
iMSCP::DbTasksProcessor::_processModuleDbTasks(iMSCP::DbTasksProcessor=HASH(0x55af0e7edbe8), "Modules::Plugin", "\x{a} SELECT plugin_id AS id, plugin_name AS name\x{a} "..., "per_item_log_file") called at /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/../../../../engine/PerlLib/iMSCP/DbTasksProcessor.pm line 62
iMSCP::DbTasksProcessor::processDbTasks(iMSCP::DbTasksProcessor=HASH(0x55af0e7edbe8)) called at /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/renew.pl line 67
eval {...} called at /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/renew.pl line 33

Display More

if i run "perl /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/renew.pl -dv" i got this message on console

Code

[WARN] (eval): Use of uninitialized value in addition (+) at /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/renew.pl line 63.

Regards

Sascha

**TheCry** · Apr 30th 2019

Ok... The first problem is fixex by installing the correct package

Code

apt-get install libarray-diff-perl

I don't understand why this package is missing..

But the second mesage still appears con console

Code

[WARN] (eval): Use of uninitialized value in addition (+) at /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/renew.pl line 63.

**Nuxwin** · Apr 30th 2019

Quote from TheCry

[WARN] (eval): Use of uninitialized value in addition (+) at /var/www/imscp/gui/plugins/LetsEncrypt/cronjobs/renew.pl line 63.

Good evening,

The version of your LE plugin (as showed in the plugin interface) is?

You could maybe show us the relevant line because it seem you're not really using latest LE plugin version. On my copy, there is not such addition (+)... The only addition (+) is done in the SQL query. Please post us the full content of the renew.pl script.

Regarding the package, it's surely because you use an old version of the LE plugin. in the CHANGELOG of the latest version (3.5.0), you can read:

Code

Fixed: Required distribution packages are not installed while plugin installation (regression fix).

**TheCry** · May 1st 2019

Hi Laurent,

here is the content of the script

Perl

#!/usr/bin/perl
# i-MSCP LetsEncrypt plugin
#
# @author Laurent Deckercq <l.declercq@nuxwin.com>
# @copyright (C) 2016-2017 Laurent Declercq <l.declercq@nuxwin.com>
# @license i-MSCP License <http://www.i-mscp.net/license-agreement.html>
use strict;
use warnings;
use FindBin;
use lib "$FindBin::Bin/../../../../engine/PerlLib", "$FindBin::Bin/../../../../engine/PerlVendor";
use Class::Autouse qw/ :nostat iMSCP::Database iMSCP::DbTasksProcessor iMSCP::Service /;
use File::Basename;
use iMSCP::Bootstrapper;
use iMSCP::Debug;
use iMSCP::Getopt;
use JSON;
sub getConfig
{
my $db = shift;
my $dbi = $db->getRawDb( );
my $config = $dbi->selectrow_hashref( "SELECT plugin_config FROM plugin WHERE plugin_name = 'LetsEncrypt'" );
!$dbi->errstr or die( $dbi->errstr );
$config or die( "Couldn't find LetsEncrypt plugin configuration in database" );
JSON->new( )->decode( $config->{'plugin_config'} );
}
my $bootstrapper = iMSCP::Bootstrapper->getInstance( );
exit unless $bootstrapper->lock( '/var/lock/imscp-letsencrypt-renew.lock', 'nowait' );
eval {
newDebug( 'letsencrypt-plugin-renew.pl.log' );
iMSCP::Getopt->parseNoDefault( sprintf( 'Usage: perl %s [OPTION]...', basename( $0 ) ).qq {
Process renewal tasks.
OPTIONS:
-d, --debug Enable debug mode.
-v, --verbose Enable verbose mode.},
'debug|d' => \&iMSCP::Getopt::debug,
'verbose|v' => \&iMSCP::Getopt::verbose
);
setVerbose( iMSCP::Getopt->verbose );
iMSCP::Bootstrapper->getInstance( )->boot(
{
config_readonly => 'yes',
norequirements => 'yes'
}
);
iMSCP::Service->getInstance( )->isRunning( 'mysql' ) or exit;
my $db = iMSCP::Database->factory( );
my $qrs = $db->doQuery(
'u', "UPDATE letsencrypt SET letsencrypt_status = ? WHERE letsencrypt_status = ? AND letsencrypt_expires <= ?",
'torenew',
'ok',
( time( )+getConfig($db)->{'renew_before_expiry'} )
);
ref $qrs eq 'HASH' or die( $qrs );
iMSCP::DbTasksProcessor->getInstance( mode => 'backend' )->process( );
};
if ($@) {
error("Couldn't process Let's Encrypt renewal tasks: %s", $@);
exit 1;
}
END { $bootstrapper->unlock( '/var/lock/imscp-letsencrypt-renew.lock' ); }
1;
__END__;

Display More

THe version ist 3.5.0

**Nuxwin** · May 1st 2019

Quote from TheCry

THe version ist 3.5.0

No.

The code from the renew.pl script you showed above is not the one from the 3.5.0 version. Please upload the 3.5.0 version again.

Thec code should look as follows:

Perl

#!/usr/bin/perl
# i-MSCP LetsEncrypt plugin
#
# @author Laurent Declercq <l.declercq@nuxwin.com>
# @license i-MSCP License <http://www.i-mscp.net/license-agreement.html>
use strict;
use warnings;
use FindBin;
use lib "$FindBin::Bin/../../../../engine/PerlLib", "$FindBin::Bin/../../../../engine/PerlVendor";
use Class::Autouse qw/ :nostat iMSCP::Database iMSCP::DbTasksProcessor iMSCP::Service /;
use File::Basename;
use iMSCP::Bootstrapper;
use iMSCP::Debug;
use iMSCP::Getopt;
use JSON;
# This script responsible for automatic renewal of SSL certificate which are
# due for renewal, according the renewal policy. It is automatically added
# as a cron job in the i-MSCP core cron file (e.g. /etc/cron.d/imscp).
#
# This script can also be run manually by administrator.
sub getConfig
{
my ($db) = @_;
my $dbi = $db->getRawDb();
local $dbi->{'RaiseError'} = 1;
my $config = $dbi->selectrow_hashref( "SELECT plugin_config FROM plugin WHERE plugin_name = 'LetsEncrypt'" );
$config or die( "Couldn't find LetsEncrypt plugin configuration in database" );
JSON->new()->decode( $config->{'plugin_config'} );
}
my $bootstrapper = iMSCP::Bootstrapper->getInstance();
exit unless $bootstrapper->lock( '/var/lock/imscp-letsencrypt-renew.lock', 'nowait' );
eval {
newDebug( 'letsencrypt-plugin-renew.pl.log' );
iMSCP::Getopt->parseNoDefault( sprintf( 'Usage: perl %s [OPTION]...', basename( $0 )) . qq{
Process renewal tasks.
OPTIONS:
-d, --debug Enable debug mode.
-v, --verbose Enable verbose mode.},
'debug|d' => \&iMSCP::Getopt::debug,
'verbose|v' => \&iMSCP::Getopt::verbose
);
setVerbose( iMSCP::Getopt->verbose );
iMSCP::Bootstrapper->getInstance()->boot( {
config_readonly => 'yes',
norequirements => 'yes'
} );
my $db = iMSCP::Database->factory();
my $qrs = $db->doQuery(
'u',
"
UPDATE letsencrypt
SET letsencrypt_status = 'torenew', letsencrypt_previous_status = NULL, letsencrypt_status_date = UNIX_TIMESTAMP()
WHERE letsencrypt_status = 'ok'
AND letsencrypt_expires <= UNIX_TIMESTAMP() + ?
",
getConfig( $db )->{'renewal_policy'} // 1814400
);
ref $qrs eq 'HASH' or die( $qrs );
iMSCP::DbTasksProcessor->getInstance( mode => 'backend' )->process();
};
if ( $@ ) {
error( sprintf( "Couldn't process Let's Encrypt renewal tasks: %s", $@ ) );
exit 1;
}
END { $bootstrapper->unlock( '/var/lock/imscp-letsencrypt-renew.lock' ); }
1;
__END__;

Display More

**TheCry** · May 1st 2019

Very strange Laurent.

I did give you the version from the panel in the plugin section. There was the vesrion 3.5.0

Now i'd uploaded the plugin again and the error does'nt appear anymore

Thank you

Let's Encrypt Renew wont work anymore

Nuxwin Apr 30th 2019

TheCry May 1st 2019

TheCry May 1st 2019

Share

Daily visitors