Issues with HASH in listener files

**UncleJ** · Jul 5th 2015

Hello everyboy,

I tried to create some listener files which allow to modify the named config based on domains but I got stuck when passing over the array. Perhaps someone may help to fix this - the final listener will be provided to the community.

This is where I am stuck - I created a listener which adds a general list of mx-entries to all domains (see here) but when I try to make this per Domain the array is not working (complete code is attached).

So this works:

Code

my %additionalMailservers = ( 'mx50' => '50' );# All dns mail-serversmy %mailserverList = %additionalMailservers;if(%mailserverList) { my @formattedEntries = (); push @formattedEntries, '; custom MX DNS entries BEGIN'; # add out-of-zone mail-servers while (my ($name, $priority) = each(%mailserverList)) { push @formattedEntries, '@ IN MX ' . $priority . ' ' . $name; }....

But this does not work:

Code

my %{$perDomainAdditionalMailservers['testdomain']} = ( 'mx40' => '40' );
# All dns mail-servers
my %mailserverList = %{$perDomainAdditionalMailservers['testdomain']};
if(%mailserverList) {
my @formattedEntries = ();
push @formattedEntries, '; custom MX DNS entries BEGIN';
# add out-of-zone mail-servers
while (my ($name, $priority) = each(%mailserverList))
{
push @formattedEntries, '@ IN MX ' . $priority . ' ' . $name;
}
....

Display More

So, perhaps anyone knows how to solve this. Thanks in advance.

Regards Jörg

**Nuxwin** · Jul 5th 2015

@UncleJ

Hello,

First, you should not talk about associative array here... In Perl we say: HASH.

I can provide a fixed version but first I need to know if the per domain MX entries take precedence over the global entries or if both, the global entries and the per domain entries much be merged together and added in the zone file.

**UncleJ** · Jul 5th 2015

@Nuxwin

Hello,

okay, I will try to remember that.

The entries should be merged. So in case that there are globally defined mx-entries and per Domain defined ones, both should be added. This should help to cover all possible combinations then (only global, only local, some global for all and special per domain, a.s.o.). In case both contain the same key (is it also a key when talking about a HASH?) the value should be taken from domain specification.

Thanks in adavance for your fix - it will also help for some other files I have nearly finished

Regards Jörg

**Nuxwin** · Jul 5th 2015

@UncleJ

Here the fixed version.

Perl

# i-MSCP Listener::Named::AddMxDNSRecords listener file
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2.1 of the License, or (at your option) any later version.
#
# This library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
#
# You should have received a copy of the GNU Lesser General Public
# License along with this library; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
#
## i-MSCP listener file modifies the zone files, adds custom out-of-zone MX DNS entries
#
package Listener::Named::AddMxDNSRecords;
use iMSCP::EventManager;
use iMSCP::TemplateParser;
#
## Configuration variables
#
# Define here your out-of-zone backup-mx mail-servers
# Please replace the entries below by your own entries
my %perDomainAdditionalMailservers = (
'testdomain.local' => {
'mx40' => '40'
},
'<domain1.tld>' => {
'<mx1-name>' => '<mx1-priority>',
'<mx2-name>' => '<mx2-priority>'
},
'<domain2.tld>' => {
'<mx1-name>' => '<mx1-priority>',
'<mx2-name>' => '<mx2-priority>'
}
);
# Please replace the entries below by your own entries
my %additionalMailservers = ( 'mx50' => '50' );
#
## Please, don't edit anything below this line
#
sub addMxDNSrecords
{
my ($tplDbFileContent, $data) = @_;
my %mxServerEntries;
if(exists $perDomainAdditionalMailservers{$data->{'DOMAIN_NAME'}}) {
%mxServerEntries = (%additionalMailservers, %{$perDomainAdditionalMailservers{$data->{'DOMAIN_NAME'}});
} else {
%mxServerEntries = %additionalMailservers;
}
if(%mxServerEntries) {
my @formattedEntries = ('; custom MX DNS entries BEGIN');
while(my($mxHost, $mxPriority) = each(%mxServerEntries) {
push @formattedEntries, sprintf("@\tIN\tMX\t%s %s", $mxHost, $mxPriority);
}
undef %mxServerEntries;
push @formattedEntries, '; custom MX DNS entries ENDING';
$tplDbFileContent = replaceBloc(
"; dmn MAIL entry BEGIN\n",
"; dmn MAIL entry ENDING\n",
"; dmn MAIL entry BEGIN\n" .
getBloc(
"; dmn MAIL entry BEGIN\n",
";dmn MAIL entry ENDING\n",
$tplDbFileContent
) .
join("\n", @formattedEntries) . "\n" .
"; dmn MAIL entry ENDING\n",
$tplDbFileContent
);
}
0;
}
sub addMxDNSrecordsSub
{
my ($wrkDbFileContent, $subEntry, $data) = @_;
my %mxServerEntries;
if(exists $perDomainAdditionalMailservers{$data->{'DOMAIN_NAME'}}) {
%mxServerEntries = (%additionalMailservers, %{$perDomainAdditionalMailservers{$data->{'DOMAIN_NAME'}});
} else {
%mxServerEntries = %additionalMailservers;
}
if(%mxServerEntries) {
my @formattedEntries = ('; custom MX DNS entries BEGIN');
while(my($mxHost, $mxPriority) = each(%mxServerEntries) {
push @formattedEntries, sprintf("@\tIN\tMX\t%s %s", $mxHost, $mxPriority);
}
undef %mxServerEntries;
push @formattedEntries, '; custom MX DNS entries ENDING';
$subEntry = replaceBloc(
"; sub MX entry BEGIN\n",
"; sub MX entry ENDING\n",
"; sub MX entry BEGIN\n" .
getBloc(
"; sub MX entry BEGIN\n",
"; sub MX entry ENDING\n",
$subEntry
) .
join("\n", @formattedEntries) . "\n" .
"; sub MX entry ENDING\n",
$subEntry
);
}
0;
}
my $eventManager = iMSCP::EventManager->getInstance();
$eventManager->register('beforeNamedAddDmnDb', \&addMxDNSrecords);
$eventManager->register('beforeNamedAddSub', \&addMxDNSrecordsSub);
1;
__END__

Display More

See also here (the same but with better indentation: http://pastebin.com/CaVdgnP5

Here, two cases are covered: Global and per domain MX entries merged together, or only global MX entries (if any)

**Nuxwin** · Jul 5th 2015

Edited my previous post in which I posted wrong fixed version... Please look again.

**Nuxwin** · Jul 5th 2015

New link: http://pastebin.com/F5tHGjKS

Issues with HASH in listener files

Share

Daily visitors