Suggestion: change CREATE USER to be implemented with GRANT

GuardMoony · Jan 19th 2016

By reviewing the code to implement multiple servers i noticed some warnings of users that could not be created ( because they already existed )

In all the install codes you added a piece of code to always try to create a user. Now a better solution ( also widely accepted with mysql and mariadb ) is to add a IDENTIFIED BY inside de GRANT function.

Example of a change i made in my fork:
https://github.com/GuardMoony/…e815859dd82819da4a04e7a06

**Nuxwin** · Jan 19th 2016

@GuardMoony

You're wrong. The code first checks if the user has been already created. If you get a warning, this is surely due to some changes you have made in your fork. Whatever. Please don't report us all changes you made in your fork. We have no interest for them.

Perl

unless("$dbUser\@$dbUserHost" ~~ @main::createdSqlUsers)

Here, the SQL user is created unless already in the @main::createdSqlUsers list which old users that were already created. We could improve the code but not in 1.2.x.

GuardMoony · Jan 20th 2016

Actually the error came up using your version 1.2.11. i think during a update but got to recheck it. Will do that tomorrow

**Nuxwin** · Jan 21st 2016

@GuardMoony

Anyway: http://dev.mysql.com/doc/refman/5.7/en/grant.html :

Code

However, use of GRANT to create accounts or define nonprivilege characteristics is deprecated as of MySQL CREATE USER or ALTER USER.

Furthermore, starting with MySQL >= 5.7.6, we will use thepassword_option provided by CREATE USER to set password expiration which is not available in GRANT statement

GuardMoony · Jan 21st 2016

Quote from Nuxwin

@GuardMoony

Furthermore, starting with MySQL >= 5.7.6, we will use thepassword_option provided by CREATE USER to set password expiration which is not available in GRANT statement

Thx for the info.

May i then suggest making use of IF NOT EXISTS like subscribed in the CREATE USER article provided by you? and combine it with ALTER USER if it exists

**Nuxwin** · Jan 21st 2016

@GuardMoony

I must first check if the [IF NOT EXISTS] is available in all supported SQL server versions (MySQL, percona, mariadb). Also, ALTER USER is not available in older versions.

Suggestion: change CREATE USER to be implemented with GRANT

Share

Daily visitors