Posts by FISA4

    1. Tell me the security issue with PM. The undefined variables in the code can i fix soon.


    2. what's wrong to adapt already existing code if it comes from one of the i-MSCP developer?
    Because you should be able to rely on it in a clean code. or? (create -> update_dmn)
    replace the insert query with update query. why rewriting the whole hostingplan checking?
    i´ve trusted in the already existing code.


    3. No, not merge and say nothing. i think you should offer constructive criticism and not call it shit (or, in this case as "insult" or "sick from reading the changelog")
    - this is my constructive criticism to you. ;)


    i only want to help but maybe sometimes people needs hints (maybe a PM with "check for undefined variables"). This need not as much time like writing a long post where you wrote:

    Quote

    Hello ;
    From my side, I would recommend our community to not use that plugin (even more the version which includes the changes made by FISA4). By using this plugin, you take many security risks (security issues, database corruption).....


    Or is it your opinion, a kind of cooperation in a community?

    1.)
    tell me where the security issues and database corruptions are !!!
    if i remember right, there were a lot of issues in i-MSCP and this issues are fixed after reporting !!!.


    2.)
    Ninos didn´t changed the code in my repository, don´t blame him.


    3.)
    I really think it´s personal agains me. And this makes me sad. :(

    Bug is fixed.
    update should not update all user data and settings.
    now the function is only updating domain related settings.
    action is renamed to update_dmn


    action for adding mails is now renamed to add_mail


    with next commit the other actions will be renamed to make the action names more clear.
    i.e.: 'terminate' -> 'terminate_dmn' or 'suspend' -> 'suspend_dmn'


    I hope it is OK for you all.

    DON´T USE THE UPDATE FUNCTION !!!


    Today i found a BIG bug in the update function.
    a lot of settings of the domain will be deleted when trying to use it with hosting_plan.


    i will review the function as soon as possible. until it works the download is deleted !!!


    greetz


    FISA4